Introduce Texture Throttling #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ondition with shaders.
… management Load Textures only when node becomes visible.
…d texture handling" This reverts commit e60bda3.
jfboeve
reviewed
Dec 18, 2024
There was a problem hiding this comment.
I wonder if it's worthwhile to make a TextureState enum so we won't have to compare strings?
There was a problem hiding this comment.
Probably? That might go nicely into your shader changes. It just got updated here because // eslint-disable-next-line @typescript-eslint/no-explicit-any is no longer needed and it auto dropped the comment from my IDE 😄
SVG changed due to Alpha fix.
jfboeve
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch the amount of textures being downloaded (source) and uploaded (core ctx creation) to the GPU to reduce load on constrained devices.
The default is set to
0where everything will be processed in a single frame, this can be reduced to any value (e.g.50or25) to limit the amount of textures being processed per frame.Todo: